Skip to content

Fix cancellation test issue #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinkydeveloper merged 1 commit into from
Mar 5, 2025
Merged

Fix cancellation test issue #460

slinkydeveloper merged 1 commit into from
Mar 5, 2025

Conversation

@slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Mar 5, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

Test Results

  7 files  ±0    7 suites  ±0   6m 9s ⏱️ + 1m 4s
 54 tests ±0   51 ✅  - 2  1 💤 ±0  0 ❌ ±0  2 🔥 +2 
223 runs  ±0  213 ✅  - 7  3 💤 ±0  0 ❌ ±0  7 🔥 +7 

For more details on these errors, see this check.

Results for commit 03e633a. ± Comparison against base commit 5118ef6.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both. 
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client, URI)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client, URI)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client, URI)[3]

dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[3]

♻️ This comment has been updated with latest results.

@slinkydeveloper
Fix cancellation test issue
03e633a 
Don't cancel child one way calls anymore
@slinkydeveloper slinkydeveloper force-pushed the issues/fix-cancellation-test branch from 6d27177 to 03e633a Compare March 5, 2025 12:05
@slinkydeveloper slinkydeveloper merged commit e1b8d7f into main Mar 5, 2025
2 of 6 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/fix-cancellation-test branch March 5, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slinkydeveloper